Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lint deps and configs #3533

Merged
merged 8 commits into from
Nov 22, 2023

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Nov 18, 2023

Description

  • Move the proto-gen dependencies to a new file. They are only used for proto file generation when we update the opentelemetry-proto version. People run into build issues when installing grpcio-tools and that shouldn't block them from running lint/docs etc on changes that are unrelated.
  • More conservative approach to version pinning to avoid surprises.
  • Expand the black ignore list, otherwise black would format everything in the virtual environment.
  • Update the testenv in the lint stage to work on any Python version.

I verified that lint, docs, and other steps work on py3.8 to py3.11 so contributors with any of the versions should be able to run them locally without any issues.

.pylintrc Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 20, 2023
@srikanthccv srikanthccv marked this pull request as ready for review November 20, 2023 06:34
@srikanthccv srikanthccv requested a review from a team November 20, 2023 06:34
@ocelotl ocelotl enabled auto-merge (squash) November 22, 2023 16:51
@ocelotl ocelotl merged commit cc8fd88 into open-telemetry:main Nov 22, 2023
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants